{aarch64,x86_64}-pc-windows-gnullvm: build host tools #140772

mati865 · 2025-05-07T21:22:32Z

This is a temporary single-release workflow to create stage0 for these targets.

I opted for bootstrapping from Linux because that's the easiest host system to work with, but once this hits beta, having dedicated Windows runners would be sensible and probably preferable.

--enable-full-tools for whatever reason doesn't seem to work when cross-compiling, because LLVM tools for the new hosts are not copied into the expected directory.

rust-lang/compiler-team#877

rustbot · 2025-05-07T21:22:37Z

r? @marcoieni

rustbot has assigned @marcoieni.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-05-07T21:22:39Z

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

mati865 · 2025-05-11T21:12:03Z

Forgot to include try-job. Fixed it.

marcoieni · 2025-05-15T09:39:36Z

This will require MCP, but I suppose we need to know how long it takes to build first.

ok, so I guess we need to try this, right?

@bors try

{aarch64,x86_64}-*-windows-gnullvm: build host tools This will require MCP, but I suppose we need to know how long it takes to build first. I opted for bootstrapping from Linux because that's the easiest host system to work with, but once this hits beta, having dedicated Windows runners would be sensible and probably preferable. `--enable-full-tools` for whatever reason doesn't seem to work when cross-compiling, because LLVM tools for the new hosts are not copied into the expected directory. And WiX that bootstrap relies upon to create .msi installers only supports Windows. I haven't tried, but it might be usable via Wine. Almost every commit is self-contained, so let me know if I should split them into separate PRs. try-job: dist-windows-gnullvm

bors · 2025-05-15T09:45:16Z

⌛ Trying commit d0b81ca with merge 9772d67...

marcoieni · 2025-05-15T13:54:32Z

maybe you need to add the job to the src/ci/github-actions/jobs.yml file?

bors · 2025-05-15T15:45:16Z

💥 Test timed out

mati865 · 2025-05-15T19:29:31Z

Oh, right. Totally forgot about it.

marcoieni · 2025-05-16T09:27:44Z

@bors try

bors · 2025-05-16T09:29:10Z

⌛ Trying commit b256449 with merge 34c404a...

{aarch64,x86_64}-*-windows-gnullvm: build host tools This will require MCP, but I suppose we need to know how long it takes to build first. I opted for bootstrapping from Linux because that's the easiest host system to work with, but once this hits beta, having dedicated Windows runners would be sensible and probably preferable. `--enable-full-tools` for whatever reason doesn't seem to work when cross-compiling, because LLVM tools for the new hosts are not copied into the expected directory. And WiX that bootstrap relies upon to create .msi installers only supports Windows. I haven't tried, but it might be usable via Wine. Almost every commit is self-contained, so let me know if I should split them into separate PRs. try-job: dist-windows-gnullvm

bors · 2025-05-16T15:09:11Z

💔 Test failed - checks-actions

mati865 · 2025-05-16T16:24:42Z

System.IO.IOException: No space left on device

Unfortunately, free CI runners are not as capable as I had hoped. I've split the jobs now, but dunno if this will be acceptable.

marcoieni · 2025-05-19T14:41:01Z

I've split the jobs now, but dunno if this will be acceptable.

yes, we prefer multiple free runner compared to 1 large runner 👍

@bors try

{aarch64,x86_64}-*-windows-gnullvm: build host tools This will require MCP, but I suppose we need to know how long it takes to build first. I opted for bootstrapping from Linux because that's the easiest host system to work with, but once this hits beta, having dedicated Windows runners would be sensible and probably preferable. `--enable-full-tools` for whatever reason doesn't seem to work when cross-compiling, because LLVM tools for the new hosts are not copied into the expected directory. And WiX that bootstrap relies upon to create .msi installers only supports Windows. I haven't tried, but it might be usable via Wine. Almost every commit is self-contained, so let me know if I should split them into separate PRs. try-job: dist-aarch64-windows-gnullvm try-job: dist-x86_64-windows-gnullvm

bors · 2025-05-19T14:42:14Z

⌛ Trying commit a84e84e with merge 9e708f5...

bors · 2025-05-19T14:49:16Z

💔 Test failed - checks-actions

marcoieni · 2025-05-19T15:41:57Z

@bors try

github-actions · 2025-06-19T03:30:46Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 044514e (parent) -> d1d8e38 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard d1d8e386c5e84c4ba857f56c3291f73c27e2d62a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-msvc-ext1: 7280.1s -> 10456.1s (43.6%)
x86_64-apple-2: 5025.2s -> 6830.3s (35.9%)
dist-x86_64-apple: 8007.9s -> 9332.3s (16.5%)
x86_64-apple-1: 9017.3s -> 7874.8s (-12.7%)
dist-aarch64-apple: 5567.3s -> 6163.9s (10.7%)
x86_64-mingw-1: 8562.6s -> 9185.7s (7.3%)
x86_64-gnu-aux: 6373.6s -> 5914.7s (-7.2%)
dist-various-1: 4189.3s -> 3905.3s (-6.8%)
mingw-check-2: 1977.4s -> 2104.9s (6.4%)
dist-x86_64-illumos: 5511.5s -> 5817.0s (5.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-06-19T10:40:21Z

Finished benchmarking commit (d1d8e38): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.5%, secondary 0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.5%	[2.5%, 4.6%]	2
Improvements ✅ (primary)	-2.5%	[-3.4%, -1.5%]	2
Improvements ✅ (secondary)	-6.0%	[-6.0%, -6.0%]	1
All ❌✅ (primary)	-2.5%	[-3.4%, -1.5%]	2

Cycles

Results (secondary -0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.4%	[2.4%, 2.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.7%, -2.7%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 693.624s -> 692.944s (-0.10%)
Artifact size: 372.05 MiB -> 372.01 MiB (-0.01%)

…Simulacrum Add windows-gnullvm hosts to the manifest I made a mistake testing rust-lang#140772 only with `rustup-toolchain-install-master` which doesn't care about the manifests. This means windows-gnullvm self-hosting will have to wait one more release, unless this change is backported to beta and a new beta release is made, which doesn't seem worth the trouble.

Rollup merge of #143031 - mati865:push-mutywntmvomx, r=Mark-Simulacrum Add windows-gnullvm hosts to the manifest I made a mistake testing #140772 only with `rustup-toolchain-install-master` which doesn't care about the manifests. This means windows-gnullvm self-hosting will have to wait one more release, unless this change is backported to beta and a new beta release is made, which doesn't seem worth the trouble.

Add windows-gnullvm hosts to the manifest I made a mistake testing rust-lang/rust#140772 only with `rustup-toolchain-install-master` which doesn't care about the manifests. This means windows-gnullvm self-hosting will have to wait one more release, unless this change is backported to beta and a new beta release is made, which doesn't seem worth the trouble.

Revert rust-lang#143031 and rust-lang#140772 due to the issue with host tools reported in https://github.com/rust-lang/rust/issue/144533. This reverts commits 508021a and d577b39.

Revert rust-lang#143031 and rust-lang#140772 due to the issue with host tools reported in https://github.com/rust-lang/rust/issue/144533. This reverts commits 508021a and d577b39. CC rust-lang#145435

Revert rust-lang#143031 and rust-lang#140772 due to the issue with host tools reported in https://github.com/rust-lang/rust/issue/144533. This reverts commits 508021a and d577b39. The decision was made in rust-lang#144659 (comment). Tracking issue: rust-lang#145435

Revert <rust-lang#143031> and <rust-lang#140772> due to the issue with host tools reported in <https://github.com/rust-lang/rust/issue/144533>. This reverts commits 508021a and d577b39. The decision was made in <rust-lang#144659 (comment)>. Tracking issue: <https://github.com/rust-lang/rust/issue/145435>

Revert #143031 and #140772 due to #144533 try-job: dist-various-1

[beta] Revert #143031 and #140772 due to #144533 The decision was made in #144659 (comment). Tracking issue: #145435 r? jieyouxu try-job: dist-various-1

rustbot assigned marcoieni May 7, 2025

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2025

This comment has been minimized.

Sign in to view

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 19, 2025

bors merged commit d1d8e38 into rust-lang:master Jun 19, 2025
11 checks passed

rustbot added this to the 1.89.0 milestone Jun 19, 2025

bors mentioned this pull request Jun 19, 2025

Fix host code appearing in Wasm binaries #137457

Merged

yutannihilation mentioned this pull request Jun 19, 2025

*-pc-windows-gnullvm target yutannihilation/savvy#373

Open

mati865 deleted the gnullvm-host branch June 22, 2025 00:10

mati865 mentioned this pull request Jun 25, 2025

Add windows-gnullvm hosts to the manifest #143031

Merged

mati865 added the relnotes Marks issues that should be documented in the release notes of the next release. label Jun 26, 2025

rustbot mentioned this pull request Jun 26, 2025

Tracking issue for release notes of #140772: {aarch64,x86_64}-pc-windows-gnullvm: build host tools #143062

Closed

cuviper removed the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 17, 2025

yutannihilation mentioned this pull request Jul 26, 2025

aarch64-pc-windows-gnullvm is now tier 2 r-rust/faq#5

Merged

Alovchin91 mentioned this pull request Jul 27, 2025

{aarch64,x86_64}-pc-windows-gnullvm host tools are missing libunwind.dll #144533

Closed

mati865 mentioned this pull request Jul 29, 2025

Tracking issue for cleanup of gnullvm building process #144656

Open

mati865 mentioned this pull request Aug 13, 2025

bootstrap: refactor mingw dist and fix gnullvm #144659

Merged

jieyouxu mentioned this pull request Aug 15, 2025

Delay {aarch64,x86_64}-pc-windows-gnullvm host tools by a release cycle #145435

Closed

rust-bors bot added a commit that referenced this pull request Aug 15, 2025

Auto merge of #145456 - mati865:revert-beta-gnullvm, r=<try>

69be3a7

Revert #143031 and #140772 due to #144533 try-job: dist-various-1

bors added a commit that referenced this pull request Aug 16, 2025

Auto merge of #145456 - mati865:revert-beta-gnullvm, r=jieyouxu

630a5f1

[beta] Revert #143031 and #140772 due to #144533 The decision was made in #144659 (comment). Tracking issue: #145435 r? jieyouxu try-job: dist-various-1

{aarch64,x86_64}-pc-windows-gnullvm: build host tools #140772

{aarch64,x86_64}-pc-windows-gnullvm: build host tools #140772

Uh oh!

Conversation

mati865 commented May 7, 2025 • edited by Noratrieb Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented May 7, 2025

Uh oh!

rustbot commented May 7, 2025

Uh oh!

mati865 commented May 11, 2025

Uh oh!

marcoieni commented May 15, 2025

Uh oh!

bors commented May 15, 2025

Uh oh!

This comment has been minimized.

marcoieni commented May 15, 2025

Uh oh!

bors commented May 15, 2025

Uh oh!

mati865 commented May 15, 2025

Uh oh!

marcoieni commented May 16, 2025

Uh oh!

bors commented May 16, 2025

Uh oh!

This comment has been minimized.

bors commented May 16, 2025

Uh oh!

mati865 commented May 16, 2025

Uh oh!

marcoieni commented May 19, 2025

Uh oh!

bors commented May 19, 2025

Uh oh!

This comment has been minimized.

bors commented May 19, 2025

Uh oh!

marcoieni commented May 19, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 19, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jun 19, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

mati865 commented May 7, 2025 •

edited by Noratrieb

Loading